[build] Remove sudo calls from build process #2015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qiluo-msft
reviewed
Sep 5, 2018
qiluo-msft
approved these changes
Sep 5, 2018
5 tasks
prsunny
added a commit
that referenced
this pull request
Nov 19, 2021
c31a362 - 2021-11-18 : [202012][Mux orch] set default as standby, change mux orch priority (#2015) [Prince Sunny] 9a9e8e6 - 2021-11-18 : [202012] Check VS test failure (#2033) [Prince Sunny] 7eaabca - 2021-11-11 : [202012] Fix random failure in PR/CI build. (#2016) [Shilong Liu] 85230fe - 2021-11-04 : [orchagent] Fix group name of port-buffer-drop in flexcounterorch.cpp (#1967) [Junchao-Mellanox] a55c2ca - 2021-11-03 : [teammgrd]: Handle LAGs cleanup gracefully on Warm/Fast reboot. (#1934) [Nazarii Hnydyn]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did/How I did it
Remove
sudo modprobe overlaycalls from Makefile.work. If user had not configured passwordless sudo on their build system, runningmakewould result in the build stopping to prompt for sudo password multiple times.In lieu of explicitly calling
sudo modprobe overlay, I have added a check to determine whether the overlay module is loaded and will fail the build if not, printing the message,ERROR: Module 'overlay' not loaded. Try running 'sudo modprobe overlay'.I have also added an instruction to README.md to notify the user to manually runsudo modprobe overlaywhen setting up his/her build environment.- How to verify it